feat: automate the update of OS libraries #13
+282
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com>
GabriFedi97
reviewed
Dec 2, 2025
Comment on lines
+15
to
+17
| DISTROS := $(shell sed -n '/variable "distributions"/,/}/ { s/^[[:space:]]*"\([^"]*\)".*/\1/p }' docker-bake.hcl) | ||
| # Default supported PostgreSQL majors | ||
| POSTGRES_MAJORS := $(shell sed -n '/variable "pgVersions"/,/]/ { s/^[[:space:]]*"\([^"]*\)".*/\1/p }' docker-bake.hcl) |
There was a problem hiding this comment.
The usage of sed here is compatible with GNU sed only and not with BSD sed, which is what gets used by default on OS X.
Should we mention this requirement somewhere or perhaps is it worth considering to run this operation through a reproducible environment, eg dagger?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main idea is that, when any of the files inside
system-libs/gets modified onmain, that will triggera new build workflow which will rebuild the target extension.
This workflow will open a new PR for a target extension that requires an update of OS libs
Closes #10